Jenkinsfiles: Simplify Orin AGX/NX zstd usage #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of writing temporary files first, zstd is now used to directly write the image to disk. Signed-off-by: Mika Tammi <[email protected]>
vjuntunen
reviewed
Nov 23, 2023
vjuntunen
approved these changes
Nov 23, 2023
|
I tried the actual command yes, but I didn't set up another instance of Jenkins to just test this :) |
|
@vjuntunen So if you can helping on testing the change it would be nice |
I have branch where I making some changes for that file about flashing and should I try that change on my branch and add it on that coming PR as well? Otherwise there might be some conflicts after I merge those other changes.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of writing temporary files first, zstd is now used to directly write the image to disk.