Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbus proxy #26

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add dbus proxy #26

merged 1 commit into from
Nov 8, 2024

Conversation

mbssrc
Copy link
Collaborator

@mbssrc mbssrc commented Nov 6, 2024

Description

This PR adds two modules:

  1. dbus-proxy module as a wrapper around xdg-dbus-proxy, which connects either system or session bus to a local socket, with filtering and policy
  2. socket proxy module that connects givc-agent instances. One of these run as server (with dbus-proxy enabled) that connects to the local socket, and the other as client where applications can connect to a socket and thus talk to the remote dbus

Other changes:

  • streamline submodules so they can be re-used across the code base
  • update flake & smaller fixes

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Tests added to simulate various scenarios. Test on Ghaf and PR in works.

@mbssrc mbssrc requested review from avnik and slakkala November 6, 2024 12:51
Copy link
Contributor

@slakkala slakkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks nice (not a Go expert though)

Some miscellany comments and questions added, nothing major.

internal/pkgs/socketproxy/controller.go Outdated Show resolved Hide resolved
internal/pkgs/socketproxy/controller.go Outdated Show resolved Hide resolved
internal/pkgs/socketproxy/controller.go Show resolved Hide resolved
api/socket/socket.proto Outdated Show resolved Hide resolved
internal/pkgs/socketproxy/controller.go Outdated Show resolved Hide resolved
internal/pkgs/socketproxy/controller.go Outdated Show resolved Hide resolved
api/socket/socket.proto Outdated Show resolved Hide resolved
api/socket/socket.proto Outdated Show resolved Hide resolved
nixos/modules/host.nix Show resolved Hide resolved
@mbssrc mbssrc force-pushed the socket-proxy branch 3 times, most recently from c68ab04 to f56fd74 Compare November 8, 2024 14:46
  - update flake
  - add dbus proxy module, using xdg-dbus-proxy
  - add socket proxy as agent module
  - add dbus test across various setups
  - re-work submodules and parameter parsing
  - smaller fixes

Signed-off-by: Manuel Bluhm <[email protected]>
Copy link
Contributor

@slakkala slakkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbssrc mbssrc merged commit 995738c into tiiuae:main Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants