Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to debloat/modularize tests #29

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Nov 13, 2024

Description

Proof of concept to splitting out test VM configs.
After recent rebasing to master it start fail test, so need to be fixed/re-done.
This PR was done for discussion/inspiration how we could improve tests.

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
@avnik avnik marked this pull request as draft November 13, 2024 11:22
@avnik avnik changed the title Attempt to debload/modularize tests Attempt to debloat/modularize tests Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant