Feat startup banner #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogonz
reviewed
Feb 23, 2024
|
|
||
| const [major, minor, patch] = gitVersion; | ||
| public static ensureGitVersion(): void { | ||
| const [major, minor, patch] = GitVersionCompatibility.getGitVersion(); |
There was a problem hiding this comment.
What happens if Git is not installed at all (or cannot be found in the PATH)? We should have a professional looking message in that case.
octogonz
reviewed
Feb 23, 2024
octogonz
approved these changes
Feb 23, 2024
Co-authored-by: Pete Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Checks
Have you run
rush changefor this change?If No, please run
rush changebefore, this is necessary.If adding a new feature, the PR's description includes:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Summary
Add a startup banner display version infos.
Detail
How to test it