-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sparo checkout support --to/--from option for direct projects selection #67
feat: Sparo checkout support --to/--from option for direct projects selection #67
Conversation
common/changes/sparo/feat-checkout-to-selector_2024-04-25-14-16.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Pete Gonzalez <[email protected]>
c11e31f
to
580e47b
Compare
I think the most breaking change from this PR is mental model, which is how we treat "sparo profile"? Before this PR: "profile" is the only core concept in sparo commands. All commands will take care of profile, which mentioned in the discussion. For example, "sparo checkout " will sync up the folders by the recorded profiles after checking out to the target branch to make everything consistency and prohibit footguns. After this PR: "profile" is changed. It's now more like a convenience way to "--to" and "--from". It unveils powerful "--to" and "--from" and more free to let users decide how to use it. As you can tell, the power is a double-edge sword. It can bring easy-to-use story and it can also make it pretty error-prone.
My proposal: |
@chengcyber thanks for your insights.
Sparo profile takes precedence at all times despite we introduced
To put it simply, |
Basic Checks
Have you run
rush change
for this change?If No, please run
rush change
before, this is necessary.If adding a new feature, the PR's description includes:
Instead of creating Sparo Profiles, sometimes I just want to checkout some projects randomly based on RushJS selector.
sparo checkout --to project-A project-B --from project-C project-D
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Summary
Detail
How to test it