Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: website build #87

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: website build #87

merged 1 commit into from
Aug 29, 2024

Conversation

chengcyber
Copy link
Member

@chengcyber chengcyber commented Aug 29, 2024

Basic Checks

Have you run rush change for this change?

  • Yes
  • No

If No, please run rush change before, this is necessary.

If adding a new feature, the PR's description includes:

  • Reason for adding this feature
  • How to use
  • A basic example

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Summary

Patch lunr.utils.warn to use console.log instead of console.warn

Detail

img_v3_02e7_60738ba2-2453-4e65-bcf2-916e3b7f40hu

Lunr prints error message with console.warn which print on stderr. The messages are treated as error message by rush build

After patching the code of lunr, it uses console.log to print the message.

How to test it

Local

@chengcyber chengcyber merged commit cd624c8 into main Aug 29, 2024
3 checks passed
@chengcyber chengcyber deleted the fix-website-build branch August 29, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants