Improve error handling to distinguishes errors #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishagg17
commented
May 22, 2021
| @@ -21,7 +21,7 @@ run-example: target/tikv-example | |||
| RUST_LOG=debug $(cur_makefile_path)/target/tikv-example | |||
|
|
|||
| target/tikv-example: target/debug/libtikv_client.a example/main.cpp | |||
| c++ $(cur_makefile_path)/example/main.cpp -o $(cur_makefile_path)/target/tikv-example -std=c++17 -g -I$(cur_makefile_path)/include -L$(cur_makefile_path)/target/debug -ltikv_client -lpthread -ldl -lssl -lcrypto | |||
| c++ $(cur_makefile_path)/example/main.cpp -o $(cur_makefile_path)/target/tikv-example -std=c++17 -g -I$(cur_makefile_path)/include -L$(cur_makefile_path)/target/debug -ltikv_client -lpthread -ldl -L/usr/local/opt/openssl/lib -I/usr/local/opt/openssl/include -lssl -lcrypto | |||
There was a problem hiding this comment.
I had to manually link ssl and lcrypto libraries so had to change this but will revert it as soon as other changes are approved.
| func(); | ||
| } catch (const std::exception &e) { | ||
| start error_message = e.what(); | ||
| int error_code = 0; |
There was a problem hiding this comment.
How should we get the error_code via stl: map or using string comparison?
There was a problem hiding this comment.
We need to define the error_code on rust binding and pass it to the cpp glue.
Signed-off-by: Anish Aggarwal <[email protected]>
|
Hi @andylokandy, I have withdrawn my application for the program but would still like to get this one completed if it's okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9
Used cxx-binding to throw custom errors.
Signed-off-by: Anish Aggarwal [email protected]