Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ping request should not be forwarded #9031

Closed
rleungx opened this issue Feb 5, 2025 · 0 comments · Fixed by #9042
Closed

ping request should not be forwarded #9031

rleungx opened this issue Feb 5, 2025 · 0 comments · Fixed by #9042
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Feb 5, 2025

Bug Report

Here is a log from 1e:

[2025/01/24 12:59:19.617 +00:00] [ERROR] [middleware.go:150] ["request failed"] [error="[PD:http:ErrSendRequest]Get \"https://mussel-prod-replace-pd-0.mussel-prod-replace-pd-peer.tidb-mussel-prod-replace.
svc.us-east-1a.mussel-prod-replace.tidb.musta.ch:2379/pd/api/v1/ping\": net/http: cannot rewind body after connection loss: Get \"https://mussel-prod-replace-pd-0.mussel-prod-replace-pd-peer.tidb-mussel-p
rod-replace.svc.us-east-1a.mussel-prod-replace.tidb.musta.ch:2379/pd/api/v1/ping\": net/http: cannot rewind body after connection loss"]

The ping request shouldn't be forwarded.
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Feb 5, 2025
@rleungx rleungx mentioned this issue Feb 7, 2025
Merged
@rleungx rleungx added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. labels Feb 20, 2025
ti-chi-bot bot added a commit that referenced this issue Feb 24, 2025
@rleungx @ti-chi-bot
*: prevent ping from forwarding (#9042)
ae0da1f 
close #9031

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Feb 24, 2025
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#9042
197a9c7 
close tikv#9031

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 24, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this issue Feb 25, 2025
@ti-chi-bot @rleungx
*: prevent ping from forwarding (#9042) (#9097)
b45ab82 
close #9031

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: prevent ping from forwarding rleungx/pd
1 participant
@rleungx