Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: prevent ping from forwarding #9042

Merged
merged 3 commits into from
Feb 24, 2025
Merged

*: prevent ping from forwarding #9042

merged 3 commits into from
Feb 24, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 7, 2025

What problem does this PR solve?

Issue Number: Close #9031.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2025
@rleungx rleungx force-pushed the ping branch 2 times, most recently from dc8c88d to ab75292 Compare February 7, 2025 09:01
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 7, 2025
@rleungx rleungx requested a review from JmPotato February 8, 2025 04:12
@rleungx
Copy link
Member Author

rleungx commented Feb 8, 2025

/retest

Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-07 11:39:13.692357647 +0000 UTC m=+10996.088579708: ☑️ agreed by lhy1024.
  • 2025-02-08 04:13:59.317844002 +0000 UTC m=+70681.714066063: ☑️ agreed by JmPotato.

@rleungx
Copy link
Member Author

rleungx commented Feb 8, 2025

/retest

Signed-off-by: Ryan Leung <[email protected]>
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (2bbeb9c) to head (46e18f0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9042      +/-   ##
==========================================
- Coverage   76.25%   76.25%   -0.01%     
==========================================
  Files         468      468              
  Lines       71695    71696       +1     
==========================================
- Hits        54673    54669       -4     
  Misses      13610    13610              
- Partials     3412     3417       +5     
Flag Coverage Δ
unittests 76.25% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Feb 24, 2025
@rleungx
Copy link
Member Author

rleungx commented Feb 24, 2025

/retest

2 similar comments
@rleungx
Copy link
Member Author

rleungx commented Feb 24, 2025

/retest

@rleungx
Copy link
Member Author

rleungx commented Feb 24, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit ae0da1f into tikv:master Feb 24, 2025
25 checks passed
@rleungx rleungx deleted the ping branch February 24, 2025 05:29
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 24, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 24, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9097.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Feb 25, 2025
close #9031

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ping request should not be forwarded
4 participants