-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: support multi-k8s in grafana dashboards (#4671) #4717
metrics: support multi-k8s in grafana dashboards (#4671) #4717
Conversation
Signed-off-by: just1900 <[email protected]>
Signed-off-by: just1900 <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ff7c27a
|
Codecov Report
@@ Coverage Diff @@
## release-5.4 #4717 +/- ##
===============================================
- Coverage 74.71% 74.68% -0.04%
===============================================
Files 265 265
Lines 27963 27963
===============================================
- Hits 20893 20884 -9
- Misses 5210 5213 +3
- Partials 1860 1866 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is an automated cherry-pick of #4671
Signed-off-by: just1900 [email protected]
What problem does this PR solve?
Issue Number: close #4673
K8s community and organizations are increasingly deploying multiple Kubernetes clusters to improve availability, isolation and scalability. Since TiDB Operator have support deploying tidb across-kubernetes, this PR will address the multi-k8s issue without affecting existing single-cluster use case.
What is changed and how it works?
What's Changed:
How it works:
kubernetes
label to identify k8s cluster in your prometheus'external_labels
.sed -i s/"hide": 2/"hide": 0/g <path/to/dashboard.json>
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note