syncer: exit broadcast as soon as possible #9018

rleungx · 2025-01-22T09:31:22Z

What problem does this PR solve?

Issue Number: Close #9017

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>

codecov · 2025-01-22T09:38:00Z

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (4eb7235) to head (77d9644).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9018      +/-   ##
==========================================
- Coverage   76.28%   76.18%   -0.10%     
==========================================
  Files         468      468              
  Lines       71422    71435      +13     
==========================================
- Hits        54484    54423      -61     
- Misses      13538    13597      +59     
- Partials     3400     3415      +15

Flag	Coverage Δ
unittests	`76.18% <87.50%> (-0.10%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

pkg/syncer/server.go

Signed-off-by: Ryan Leung <[email protected]>

JmPotato · 2025-01-24T01:47:00Z

pkg/syncer/server.go

+		var failed []string
+		s.mu.RLock()
+		for name, sender := range s.mu.streams {
+			err := sender.Send(regions)


Do we need to check ctx.Done here as well?

Signed-off-by: Ryan Leung <[email protected]>

ti-chi-bot · 2025-02-11T07:50:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JmPotato,nolouch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-02-11T07:50:14Z

[LGTM Timeline notifier]

Timeline:

2025-01-23 08:57:13.60339226 +0000 UTC m=+343960.934311657: ☑️ agreed by nolouch.
2025-02-11 07:50:13.367277567 +0000 UTC m=+342855.763499628: ☑️ agreed by JmPotato.

rleungx · 2025-02-11T08:46:31Z

/retest

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2025-02-12T02:34:33Z

In response to a cherrypick label: new pull request created to branch release-7.1: #9069.
But this PR has conflicts, please resolve them!

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2025-02-12T02:34:34Z

In response to a cherrypick label: new pull request created to branch release-7.5: #9070.
But this PR has conflicts, please resolve them!

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2025-02-12T02:34:35Z

In response to a cherrypick label: new pull request created to branch release-6.1: #9071.
But this PR has conflicts, please resolve them!

ti-chi-bot · 2025-02-12T02:34:35Z

In response to a cherrypick label: new pull request created to branch release-8.1: #9072.
But this PR has conflicts, please resolve them!

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2025-02-12T02:34:36Z

In response to a cherrypick label: new pull request created to branch release-5.4: #9073.
But this PR has conflicts, please resolve them!

ti-chi-bot · 2025-02-12T02:34:36Z

In response to a cherrypick label: new pull request created to branch release-8.5: #9074.

ti-chi-bot · 2025-02-12T02:34:38Z

In response to a cherrypick label: new pull request created to branch release-6.5: #9075.
But this PR has conflicts, please resolve them!

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

close #9017 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

close #9017 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

close #9017 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2025

exit broadcast as soon as possible

3f64d88

Signed-off-by: Ryan Leung <[email protected]>

rleungx force-pushed the exit-broadcast-immediately branch from fae0a07 to 3f64d88 Compare January 22, 2025 09:38

rleungx requested a review from nolouch January 23, 2025 02:10

nolouch reviewed Jan 23, 2025

View reviewed changes

pkg/syncer/server.go Outdated Show resolved Hide resolved

address the comment

995d25c

Signed-off-by: Ryan Leung <[email protected]>

rleungx requested review from nolouch and JmPotato January 23, 2025 07:41

nolouch approved these changes Jan 23, 2025

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 23, 2025

JmPotato reviewed Jan 24, 2025

View reviewed changes

address the comment

2c312d8

Signed-off-by: Ryan Leung <[email protected]>

rleungx requested a review from JmPotato February 11, 2025 04:08

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Feb 11, 2025

JmPotato approved these changes Feb 11, 2025

View reviewed changes

ti-chi-bot bot added the lgtm label Feb 11, 2025

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 11, 2025

Merge branch 'master' into exit-broadcast-immediately

77d9644

ti-chi-bot bot merged commit cbb4dfe into tikv:master Feb 11, 2025
25 checks passed

rleungx deleted the exit-broadcast-immediately branch February 11, 2025 08:57

ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Feb 12, 2025

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 12, 2025

This is an automated cherry-pick of tikv#9018

93bb83b

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 12, 2025

This is an automated cherry-pick of tikv#9018

d05c709

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Feb 12, 2025

syncer: exit broadcast as soon as possible (#9018) #9069

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 12, 2025

This is an automated cherry-pick of tikv#9018

461c16a

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 12, 2025

This is an automated cherry-pick of tikv#9018

0fdfcc2

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Feb 12, 2025

syncer: exit broadcast as soon as possible (#9018) #9070

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 12, 2025

This is an automated cherry-pick of tikv#9018

50c73d4

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

This was referenced Feb 12, 2025

syncer: exit broadcast as soon as possible (#9018) #9071

Merged

syncer: exit broadcast as soon as possible (#9018) #9072

Merged

This was referenced Feb 12, 2025

syncer: exit broadcast as soon as possible (#9018) #9073

Closed

syncer: exit broadcast as soon as possible (#9018) #9074

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 12, 2025

This is an automated cherry-pick of tikv#9018

7768520

close tikv#9017 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Feb 12, 2025

syncer: exit broadcast as soon as possible (#9018) #9075

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025

syncer: exit broadcast as soon as possible (#9018) (#9074)

20dd6ba

close #9017 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

syncer: exit broadcast as soon as possible #9018

syncer: exit broadcast as soon as possible #9018

rleungx commented Jan 22, 2025

codecov bot commented Jan 22, 2025 •

edited

Loading

JmPotato Jan 24, 2025

rleungx Feb 11, 2025

ti-chi-bot bot commented Feb 11, 2025

ti-chi-bot bot commented Feb 11, 2025

rleungx commented Feb 11, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

syncer: exit broadcast as soon as possible #9018

syncer: exit broadcast as soon as possible #9018

Conversation

rleungx commented Jan 22, 2025

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

codecov bot commented Jan 22, 2025 • edited Loading

Codecov Report

JmPotato Jan 24, 2025

Choose a reason for hiding this comment

rleungx Feb 11, 2025

Choose a reason for hiding this comment

ti-chi-bot bot commented Feb 11, 2025

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

rleungx commented Feb 11, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

ti-chi-bot commented Feb 12, 2025

codecov bot commented Jan 22, 2025 •

edited

Loading