Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix confusing error #9050

Merged
merged 1 commit into from
Feb 11, 2025
Merged

client: fix confusing error #9050

merged 1 commit into from
Feb 11, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 10, 2025

What problem does this PR solve?

Issue Number: Close #9036

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2025
@rleungx rleungx changed the title client: fix log client: fix confusing error Feb 10, 2025
@rleungx rleungx requested review from JmPotato and lhy1024 February 11, 2025 03:26
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 11, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 11, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-11 04:01:58.533007448 +0000 UTC m=+329160.929229505: ☑️ agreed by lhy1024.
  • 2025-02-11 04:37:03.665839424 +0000 UTC m=+331266.062061480: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot merged commit aed98ba into tikv:release-7.1 Feb 11, 2025
19 checks passed
@rleungx rleungx deleted the fix-log-2 branch February 11, 2025 06:32
@rleungx rleungx added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 11, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 11, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9061.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Feb 11, 2025
close #9036

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants