Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add lock for forward tso stream (#9095) #9106

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9095

What problem does this PR solve?

Issue Number: Close #9091

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
go test -benchmem -run=^$ -bench ^BenchmarkForwardTsoConcurrently$ github.com/tikv/pd/tests/integrations/mcs/tso -benchtime 120s

client = 3
164         776899433 ns/op        52592338 B/op     446288 allocs/op
182         779831256 ns/op        52671058 B/op     446771 allocs/op
176         776116538 ns/op        52677991 B/op     446741 allocs/op

client = 1
386         342842281 ns/op        17493004 B/op     146447 allocs/op
390         344128967 ns/op        17487349 B/op     146318 allocs/op
379         356701493 ns/op        17528155 B/op     146427 allocs/op

Release note

None.

Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Feb 27, 2025
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.61%. Comparing base (727c208) to head (212b7cc).
Report is 1 commits behind head on release-8.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.5    #9106      +/-   ##
===============================================
- Coverage        75.63%   75.61%   -0.03%     
===============================================
  Files              462      462              
  Lines            72379    72389      +10     
===============================================
- Hits             54744    54736       -8     
- Misses           14123    14155      +32     
+ Partials          3512     3498      -14     
Flag Coverage Δ
unittests 75.61% <93.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 27, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 28, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 28, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-27 09:03:25.642777458 +0000 UTC m=+519353.595935723: ☑️ agreed by rleungx.
  • 2025-02-28 02:15:05.068748124 +0000 UTC m=+581253.021906382: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 2da8160 into tikv:release-8.5 Feb 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants