Deflake perf context test #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: no
v01dstar
force-pushed
the
deflake-perf-context-test
branch
from
ae9b6fa to
1f084ea
Compare
ti-chi-bot
bot
added
size/XS
v01dstar
force-pushed
the
deflake-perf-context-test
branch
from
1f084ea to
dd5dbee
Compare
ti-chi-bot
bot
added
dco-signoff: yes
|
/run-all-tests |
LykxSassinator
approved these changes
Sep 27, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/merge |
Summary: We saw failures like ``` db/perf_context_test.cc:952: Failure Expected: (next_count) > (count), actual: 26699 vs 26699 ``` I can repro by running the test repeatedly and the test fails with different seek keys. So the cause is likely not with Seek() implementation. I found that `clock_gettime(CLOCK_THREAD_CPUTIME_ID, &ts);` can return the same time when called repeatedly. However, I don't know if Seek() is fast enough that this happened during continuous test. Pull Request resolved: facebook#12252 Test Plan: `gtest_parallel.py --repeat=10000 --workers=1 ./perf_context_test --gtest_filter="PerfContextTest.CPUTimer"` Reviewed By: ajkr Differential Revision: D52912751 Pulled By: cbi42 fbshipit-source-id: 8985ae93baa99cdf4b9136ea38addd2e41f4b202 Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
deflake-perf-context-test
branch
from
dd5dbee to
0c01228
Compare
LykxSassinator
approved these changes
Sep 27, 2024
Connor1996
approved these changes
Sep 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking facebook@ec5b1be
Test-only:
PerfContextTest.CPUTimerwas flaky.