Add enable_multi_thread_write as deprecated option #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_multi_thread_write
was an option provided in early TiKV versions (5.4 is a known one). A cluster upgrades from early versions to newer versions may encounter[FATAL] [lib.rs:479 ["failed to load_latest_options "Invalid argument: Could not find option: : enable_multi_thread_write""]
.Although we
load_lastest_options()
withignore_unknown_options=true
, the problem still occurs, becauseignore_unknown_options
is to prevent downgrade compatibility issues, e.g. an option exists in option file that is created by newer versions of RocksDB, but does not exist in the running version. see:rocksdb/options/options_parser.cc
Lines 288 to 297 in e255444