Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable_multi_thread_write as deprecated option #405

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

v01dstar
Copy link

@v01dstar v01dstar commented Feb 6, 2025

enable_multi_thread_write was an option provided in early TiKV versions (5.4 is a known one). A cluster upgrades from early versions to newer versions may encounter [FATAL] [lib.rs:479 ["failed to load_latest_options "Invalid argument: Could not find option: : enable_multi_thread_write""].

Although we load_lastest_options() with ignore_unknown_options=true, the problem still occurs, because ignore_unknown_options is to prevent downgrade compatibility issues, e.g. an option exists in option file that is created by newer versions of RocksDB, but does not exist in the running version. see:

// If the option file is not generated by a higher minor version,
// there shouldn't be any unknown option.
if (config_options.ignore_unknown_options &&
section == kOptionSectionVersion) {
if (db_version[0] < ROCKSDB_MAJOR || (db_version[0] == ROCKSDB_MAJOR &&
db_version[1] <= ROCKSDB_MINOR)) {
config_options.ignore_unknown_options = false;
}
}

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 7, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 7, 2025
Copy link

ti-chi-bot bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LykxSassinator, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LykxSassinator,overvenus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 7, 2025
Copy link

ti-chi-bot bot commented Feb 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-07 01:58:33.539434778 +0000 UTC m=+409785.071846775: ☑️ agreed by LykxSassinator.
  • 2025-02-07 03:35:23.751128079 +0000 UTC m=+415595.283540061: ☑️ agreed by overvenus.

@ti-chi-bot ti-chi-bot bot merged commit 4373620 into tikv:8.10.tikv Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants