Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd_client: fix item value type #14106

Merged
merged 6 commits into from
Feb 2, 2023
Merged

pd_client: fix item value type #14106

merged 6 commits into from
Feb 2, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jan 31, 2023

Signed-off-by: husharp [email protected]

What is changed and how it works?

Issue Number: Close #14104 Should merge after pingcap/kvproto#1051

What's Changed:

We need to use the new field to support item value as bytes to avoid proto string check failures.

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@HuSharp
fix item value type
8d41896 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 31, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. contribution This PR is from a community contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2023
@HuSharp
update ru
630a02c 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2023
@HuSharp
update test
b49009c 
Signed-off-by: husharp <[email protected]>
glorv
glorv reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@HuSharp HuSharp marked this pull request as ready for review February 1, 2023 07:46
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2023
@glorv glorv mentioned this pull request Feb 1, 2023
Merged
@HuSharp
update kvproto
5dfbd58 
Signed-off-by: husharp <[email protected]>
glorv
glorv approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 2, 2023
@glorv
Copy link
Contributor

glorv commented Feb 2, 2023

/cc @Connor1996

@ti-chi-bot ti-chi-bot requested a review from Connor1996 February 2, 2023 02:35
@HuSharp
merge upstream
45aca44 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 2, 2023
@HuSharp
Copy link
Member Author

HuSharp commented Feb 2, 2023

/test

1 similar comment
@HuSharp
Copy link
Member Author

HuSharp commented Feb 2, 2023

/test

@YangKeao
Copy link
Member

YangKeao commented Feb 2, 2023

/run-build-arm64

@ti-chi-bot
Copy link
Member

@BornChanger: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Connor1996
Connor1996 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2023
@Connor1996
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45aca44

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2023
@ti-chi-bot ti-chi-bot merged commit d1d2920 into tikv:master Feb 2, 2023
@ti-chi-bot ti-chi-bot added this to the Pool milestone Feb 2, 2023
@HuSharp HuSharp deleted the fix_item_value_type branch February 2, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

pd_client: provide bytes struct to global item value
6 participants
@HuSharp @ti-chi-bot @glorv @YangKeao @Connor1996 @BornChanger