Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra data tables #17

Merged
merged 5 commits into from
Nov 17, 2017
Merged

Conversation

zerebubuth
Copy link
Member

Added tables for:

  • Who's On First neighbourhoods
  • Land and water openstreetmapdata.com polygons.
  • Natural Earth 10m urban area polygons.

Also added a command line entry point for raw_tiles, making it easier to run ad-hoc tests, and some extra unit tests.

Matt Amos added 5 commits November 9, 2017 11:18
This is done through a "GenericTableSource", which is useful for simple queries in single SQL files. I.e: not complicated stuff like ways/relations.
Copy link
Member

@rmarianski rmarianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better for the calling code and the api not to have to know about table readers and connection management, but since we only have sql sources I don't think it would practically buy us very much.

@zerebubuth
Copy link
Member Author

I think it would be better for the calling code and the api not to have to know about table readers and connection management.

I agree, but I couldn't immediately think of a better way to do it. I've added #18 to track that and figure out what would be a good way of fixing this.

@zerebubuth zerebubuth merged commit c7a042c into master Nov 17, 2017
@zerebubuth zerebubuth deleted the zerebubuth/add-extra-data-tables branch November 17, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants