Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make testbenches selftesting #302

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Make testbenches selftesting #302

merged 5 commits into from
Dec 9, 2024

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Nov 21, 2024 •
edited
Loading

Description

Make testbenches selftesting by:

  1. Exit with the right error code
  2. Comparing the output with the expected result

Fixes # (issues)

Type of change

  • Feature (non breaking change which adds functionality)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history

@dehanj dehanj force-pushed the make_tb_selftesting branch 2 times, most recently from e32f413 to dd20154 Compare November 22, 2024 12:51
@dehanj dehanj changed the title Make tb selftesting Fix timer core bug + testbenches selftesting in CI Nov 22, 2024
@dehanj dehanj marked this pull request as ready for review November 22, 2024 12:52
@dehanj dehanj changed the title Fix timer core bug + testbenches selftesting in CI Make testbenches selftesting in CI Nov 22, 2024
@dehanj dehanj force-pushed the make_tb_selftesting branch 2 times, most recently from 2f7ec34 to 4e7c511 Compare November 22, 2024 13:03
@dehanj dehanj requested review from jthornblad and agren November 22, 2024 13:04
@dehanj dehanj linked an issue Nov 22, 2024 that may be closed by this pull request
Make testbenches self testing, and with correct exit code #185
Closed
@dehanj
tb: Make tb_tk1.v selftesting
09c3d9b 
- Exit with the right error code
@dehanj dehanj force-pushed the make_tb_selftesting branch from 4e7c511 to 8af3259 Compare December 9, 2024 08:47
@dehanj dehanj changed the title Make testbenches selftesting in CI Make testbenches selftesting Dec 9, 2024
@dehanj dehanj force-pushed the make_tb_selftesting branch from 8af3259 to 28b9755 Compare December 9, 2024 11:34
dehanj added 4 commits December 9, 2024 13:55
@dehanj
tb: Make tb_tk1_spi_master.v selftesting
c547042 
- Compare against expected value
- Exit with the correct error code
@dehanj
tb: Make touch_sense selftesting
ac853c8 
- Check for expected word
- Exit with the right error code
@dehanj
tb: Make trng selftesting
c637c74 
- Exit with the right error code
@dehanj
tb: Make uart selftesting
66888a3 
- Exit with the right exit code
@dehanj dehanj force-pushed the make_tb_selftesting branch from 28b9755 to 66888a3 Compare December 9, 2024 12:55
@dehanj dehanj merged commit 66888a3 into main Dec 9, 2024
5 checks passed
@dehanj dehanj deleted the make_tb_selftesting branch December 9, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agren agren agren approved these changes

@jthornblad jthornblad Awaiting requested review from jthornblad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make testbenches self testing, and with correct exit code
2 participants
@dehanj @agren