Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to partially un-highlight selected text. #433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/modules/rangy-highlighter.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,43 @@ rangy.createModule("Highlighter", ["ClassApplier"], function(api, module) {
}
},

/**
* Removes all highlights for the currently selected text and preserves any existing highlights
* that were partially selected.
*/
removeHighlightsFromSelection: function(containerElementId) {
var _self = this;
var doc = this.doc;
var currentSelection = api.getSelection(doc);
var scope = getContainerElement(currentSelection.win.document, containerElementId);
var charRanges = [];

forEach(currentSelection.getAllRanges(), function(range) {
var charRangeScoped = _self.converter.rangeToCharacterRange(range, scope);
charRanges.push(charRangeScoped);
});

var newHighlights = [];
var intersectingHighlights = this.getHighlightsInSelection(currentSelection);
if (intersectingHighlights.length > 0) {
forEach(charRanges, function(charRange) {
//for each charRange in the selection, see if it intersects with any existing highlights
//and preserve unselected portions of existing highlights
forEach(intersectingHighlights, function(highlight) {
var complements = highlight.characterRange.getComplements(charRange);
forEach(complements, function(complement) {
newHighlights.push(new Highlight(doc, complement, highlight.classApplier, _self.converter, null, containerElementId));
});
});
});
}
this.removeHighlights(intersectingHighlights);
forEach(newHighlights, function(highlight) {
highlight.apply();
_self.highlights.push(highlight);
});
},

removeAllHighlights: function() {
this.removeHighlights(this.highlights);
},
Expand Down
67 changes: 66 additions & 1 deletion test/highlightertests.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,69 @@ xn.test.suite("Highlighter module tests", function(s) {
highlighter.highlightSelection("c1", { selection: rangy.getSelection() });
});

}, false);
s.test("partial unhighlight test", function(t) {
var applier = rangy.createClassApplier("yellow");
var highlighter = rangy.createHighlighter();
highlighter.addClassApplier(applier);

var testEl = document.getElementById("test");
var range = rangyTestUtils.createRangeInHtml(testEl, '[one two three four]');
range.select();

highlighter.highlightSelection("yellow");

t.assertEquals(highlighter.highlights[0].characterRange.start, 9);
t.assertEquals(highlighter.highlights[0].characterRange.end, 27);

var range2 = rangyTestUtils.createRangeInHtml(testEl, '[one two] three four');
range2.select();

highlighter.removeHighlightsFromSelection();

t.assertEquals(highlighter.highlights[0].characterRange.start, 16);
t.assertEquals(highlighter.highlights[0].characterRange.end, 27);
});

s.test("partial unhighlight test 2", function(t) {
var yellow = rangy.createClassApplier("yellow");
var green = rangy.createClassApplier("green");
var highlighter = rangy.createHighlighter();
highlighter.addClassApplier(yellow);
highlighter.addClassApplier(green);

var testEl = document.getElementById("test");
var range = rangyTestUtils.createRangeInHtml(testEl, '[one two three four]');
range.select();

highlighter.highlightSelection("yellow");

var range2 = rangyTestUtils.createRangeInHtml(testEl, '[one two] three four');
range2.select();
highlighter.highlightSelection("green");

//yellow
t.assertEquals(highlighter.highlights[0].classApplier.className, "yellow");
t.assertEquals(highlighter.highlights[0].characterRange.start, 16);
t.assertEquals(highlighter.highlights[0].characterRange.end, 27);
//green
t.assertEquals(highlighter.highlights[1].classApplier.className, "green");
t.assertEquals(highlighter.highlights[1].characterRange.start, 9);
t.assertEquals(highlighter.highlights[1].characterRange.end, 16);

var range3 = rangyTestUtils.createRangeInHtml(testEl, 'one [two three] four');
range3.select();

highlighter.removeHighlightsFromSelection();

//yellow
t.assertEquals(highlighter.highlights[0].classApplier.className, "yellow");
t.assertEquals(highlighter.highlights[0].characterRange.start, 22);
t.assertEquals(highlighter.highlights[0].characterRange.end, 27);
//green
t.assertEquals(highlighter.highlights[1].classApplier.className, "green");
t.assertEquals(highlighter.highlights[1].characterRange.start, 9);
t.assertEquals(highlighter.highlights[1].characterRange.end, 13);

});

}, false);