Use of UTC datetime instead of local datetime #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the Hessian protocol and not local date time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The Hessian protocol specifies that a date should be represented as a 64-bit long of milliseconds since Jan 1 1970 00:00H, UTC (ref: http://hessian.caucho.com/doc/hessian-serialization.html##date)
In the current implementation, there is a conversion from that UTC date to a C# DateTime with the specification that the DateTime object is expressed in local time. Moreover, there is an additional offset added to the received date. That offset converts the UTC date to a local date in CET zone (UTC+1).
I think that the Hessian client should not deal with such local time concern but should instead serves the date as UTC date (as the protocol states) and leave the consumer of that date decide what to do with it.
The current pull request removes the arbitrary conversion to CET zone and only deals with UTC date time at serialization and deserialization time.
Regards,
Gilles