Removed unnecessary variables (sonata-project#429)

timwentzell · Jan 6, 2021 · 831712a · 831712a
1 parent ada9b89
commit 831712a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/Writer/CsvWriter.php b/src/Writer/CsvWriter.php
@@ -138,10 +138,12 @@ public function write(array $data): void
         }
 
         // prevent csv injection
-        $patterns = ['/^=/', '/^\+/', '/^-/', '/^@/'];
-        $replace = ['!=', '!+', '!-', '!@'];
         foreach ($data as $key => $value) {
-            $data[$key] = preg_replace($patterns, $replace, $value);
+            $data[$key] = preg_replace(
+                ['/^=/', '/^\+/', '/^-/', '/^@/'],
+                ['\'=', '\'+', '\'-', '\'@'],
+                $value
+            );
         }
 
         $result = @fputcsv($this->file, $data, $this->delimiter, $this->enclosure, $this->escape);

diff --git a/src/Writer/XlsWriter.php b/src/Writer/XlsWriter.php
@@ -79,10 +79,12 @@ public function write(array $data): void
 
         fwrite($this->file, '<tr>');
         // prevent xls injection
-        $patterns = ['/^=/', '/^\+/', '/^-/', '/^@/'];
-        $replace = ['!=', '!+', '!-', '!@'];
         foreach ($data as $value) {
-            fwrite($this->file, sprintf('<td>%s</td>', preg_replace($patterns, $replace, $value)));
+            fwrite($this->file, sprintf('<td>%s</td>', preg_replace(
+                ['/^=/', '/^\+/', '/^-/', '/^@/'],
+                ['\'=', '\'+', '\'-', '\'@'],
+                $value
+            )));
         }
         fwrite($this->file, '</tr>');