-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer createKey() to register a new API key. #9
base: master
Are you sure you want to change the base?
Conversation
Mm.....This commits are too long to read. It should squash them to the less commits when merging this PR. |
…compression count, paying state and email address when they are returned from validate() calls.
private static $client = NULL; | ||
|
||
public static function setKey($key) { | ||
self::$key = $key; | ||
self::$client = NULL; | ||
} | ||
|
||
public static function getKey() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should use PHP_CodeSniffer
or php-cs-fixer
to fix PSR-2
coding style.
function emailAddress() { | ||
return Tinify::getEmailAddress(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These methods are very strange.
They looks similar. The duplicate should be removed.
… returned from the /keys endpoint.
Would love to see this in production! I got two quick questions:
|
Hi there! Once we have implemented the same logic for the other libraries we will put this into production and update the documentation.
|
Rebase master on create-key branch
No description provided.