Skip to content

Commit

Permalink
fixing kubevip documented value paths (#122)
Browse files Browse the repository at this point in the history
## Description


Updating docs to provide correct paths

## Why is this needed



Fixes: #121 

## How Has This Been Tested?




I tested by adding 
```yaml
stack: 
  kubevip:
    enabled: false
```
to my helm overrides and confirmed it disabled the kubevip deployment.

## How are existing users impacted? What migration steps/scripts do we need?



If they were following the docs, no configurations were actually set.

## Checklist:

I have:

- [x] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
  • Loading branch information
mergify[bot] authored Aug 29, 2024
2 parents feae73e + 9b806ff commit 9f6749f
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions tinkerbell/stack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ helm upgrade stack-release stack/ --namespace tink-system --wait

| Name | Description | Value |
| ---- | ----------- | ----- |
| `kubevip.enabled` | Enable the deployment of the kube-vip load balancer | `true` |
| `kubevip.name` | Name for the kube-vip load balancer service | `kube-vip` |
| `kubevip.image` | Image to use for the kube-vip load balancer | `ghcr.io/kube-vip/kube-vip:v0.5.0` |
| `kubevip.imagePullPolicy` | Image pull policy to use for kube-vip | `IfNotPresent` |
| `kubevip.roleName` | Role name to use for the kube-vip load service | `kube-vip-role` |
| `kubevip.roleBindingName` | Role binding name to use for the kube-vip load service | `kube-vip-rolebinding` |
| `kubevip.interface` | Interface to use for advertizing the load balancer IP. Leaving it unset to allow Kubevip to auto discover the interface to use. | `""` |
| `stack.kubevip.enabled` | Enable the deployment of the kube-vip load balancer | `true` |
| `stack.kubevip.name` | Name for the kube-vip load balancer service | `kube-vip` |
| `stack.kubevip.image` | Image to use for the kube-vip load balancer | `ghcr.io/kube-vip/kube-vip:v0.5.0` |
| `stack.kubevip.imagePullPolicy` | Image pull policy to use for kube-vip | `IfNotPresent` |
| `stack.kubevip.roleName` | Role name to use for the kube-vip load service | `kube-vip-role` |
| `stack.kubevip.roleBindingName` | Role binding name to use for the kube-vip load service | `kube-vip-rolebinding` |
| `stack.kubevip.interface` | Interface to use for advertizing the load balancer IP. Leaving it unset to allow Kubevip to auto discover the interface to use. | `""` |

### DHCP Relay Parameters

Expand Down

0 comments on commit 9f6749f

Please sign in to comment.