Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint schemes when PRs are created and merged #15

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

JamyGolden
Copy link
Member

  • Add linting (yamllint and small shell script) to make sure yaml files are formatted in an acceptable way and ensure the 5 properties exist (so someone doesn't accidentally leave out system or variant)
  • Run linting on PR creation and PR merge to primary branch with github action
  • Fix .github/ISSUE_TEMPLATE/config.yml yaml error caught by yamllint

@JamyGolden JamyGolden requested review from belak and FredHappyface May 1, 2024 21:38
@JamyGolden JamyGolden force-pushed the jamy/feature/add-yaml-linting branch from 2d205b9 to aaef688 Compare May 1, 2024 21:41
@JamyGolden JamyGolden force-pushed the jamy/feature/add-yaml-linting branch from 96c4111 to 9dbab70 Compare May 1, 2024 21:57
Copy link

@FredHappyface FredHappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Good to see some linting for the schemes

@sergiorussia
Copy link
Contributor

@JamyGolden any chance to merge? :)

@JamyGolden
Copy link
Member Author

@sergiorussia thanks for pinging! I think I was waiting for another review but yeah I'll merge it now 😄

@JamyGolden JamyGolden merged commit bc4189b into spec-0.11 Aug 21, 2024
1 check passed
@JamyGolden JamyGolden deleted the jamy/feature/add-yaml-linting branch August 21, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants