Added shutdown params + small refactoring

Project.toml

@@ -1,7 +1,7 @@
 name = "Plugins"
 uuid = "231a7ae5-8495-40ed-9891-ff920a14b9bd"
 authors = ["Krisztián Schaffer"]
-version = "0.1.1"
+version = "0.1.2"
 
 [compat]
 julia = "1.3"

src/Plugins.jl

@@ -7,8 +7,8 @@ export PluginStack, Plugin, hooks, symbol, setup!, shutdown!
 abstract type Plugin end
 
 symbol(plugin::Plugin) = :nothing
-setup!(plugin::Plugin, scheduler) = nothing
-shutdown!(plugin::Plugin) = nothing
+setup!(plugin::Plugin, x...) = nothing
+shutdown!(plugin::Plugin, x...) = nothing
 
 struct PluginStack
     plugins::Array{Plugin}
@@ -27,25 +27,27 @@ struct HookList{TNext, THandler, TPlugin, TFramework}
     framework::TFramework
 end
 
+HookListTerminal = HookList{Nothing, Nothing, Nothing, Nothing}
+
 @inline function (hook::HookList)(params...)::Bool
     if hook.handler(hook.plugin, hook.framework, params...) !== false
         return hook.next(params...)
     end
     return false
 end
 
-(hook::HookList{Nothing, T, Nothing, Nothing})(::Vararg{Any}) where T = true
+(hook::HookListTerminal)(::Vararg{Any}) = true
 
-length(l::HookList{Nothing, T, Nothing, Nothing}) where T = 0
+length(l::HookListTerminal) = 0
 length(l::HookList) = 1 + length(l.next)
 
 iterate(l::HookList) = (l, l.next)
 iterate(l::HookList, state) = isnothing(state) ? nothing : (state, state.next)
-iterate(l::HookList, state::HookList{Nothing, T, Nothing, Nothing}) where T = nothing
+iterate(l::HookList, state::HookListTerminal) = nothing
 
 function hooks(plugins::Array{TPlugins}, handler::THandler, framework::TFramework) where {TFramework, THandler, TPlugins}
     if length(plugins) == 0
-        return HookList(nothing, nothing, nothing, nothing)
+        return HookListTerminal(nothing, nothing, nothing, nothing)
     end
     plugin = plugins[1]
     if length(methods(handler, (typeof(plugin), TFramework, Vararg{Any}))) > 0

test/runtests.jl

@@ -1,5 +1,5 @@
 using Plugins
-import Plugins.symbol, Plugins.setup!
+import Plugins.symbol, Plugins.setup!, Plugins.setup!
 using Test
 
 struct Framework
@@ -189,7 +189,7 @@ end
         @test setup!(app.plugins, app).allok == true
         @test plugin.setupcalledwith === app
 
-        shutdown!(app.plugins, app)
+        @test shutdown!(app.plugins, app).allok == true
         @test plugin.shutdowncalledwith === app
         @test shutdown!(app.plugins, 42).allok === false
         @test plugin.shutdowncalledwith === 42