Fixed return value of unhandled hook

tisztamo · Jun 23, 2020 · c06829e · c06829e
1 parent 211fb7c
commit c06829e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Plugins.jl b/src/Plugins.jl
@@ -36,7 +36,7 @@ HookListTerminal = HookList{Nothing, Nothing, Nothing, Nothing}
     return true
 end
 
-(hook::HookListTerminal)(::Vararg{Any}) = true
+(hook::HookListTerminal)(::Vararg{Any}) = false
 
 length(l::HookListTerminal) = 0
 length(l::HookList) = 1 + length(l.next)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -127,6 +127,11 @@ deferred_init(plugin::LifeCycleTestPlugin, data) = plugin.deferredinitcalledwith
         @test innerplugin.hook2count == 0
     end
 
+    @testset "Unhandled hook returns false" begin
+        app = Framework([EmptyPlugin()])
+        @test hooks(app, hook1_handler)() == false
+    end
+
     @testset "Framework goes through" begin
         frameworktestapp = Framework([EmptyPlugin(), FrameworkTestPlugin()])
         hooks(frameworktestapp, hook1_handler)()