fix: recover files from git submodules #1748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rodrigorfk
force-pushed
the
fix-recover-file-within-submodule
branch
from
d8ffb12 to
13ceaad
Compare
jackton1
force-pushed
the
fix-recover-file-within-submodule
branch
3 times, most recently
from
4aa86ef to
206d45f
Compare
jackton1
force-pushed
the
fix-recover-file-within-submodule
branch
from
206d45f to
9a0fa8c
Compare
|
Hi @rodrigorfk, thank you for pushing a fix for this. Given the complexity of the fix, I have decided to implement a simplified version that only modifies the affected function Thanks once again much appreciated. |
|
Hi @all-contributors please add @rodrigorfk for code test and bug |
|
I've put up a pull request to add @rodrigorfk! 🎉 |
|
@jackton1 , thank you very much for looking into this and putting together a simplified version of the fix, totally make sense, will test the newly release version with my particular use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1747