Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let django handle SIGTERM #1725

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Oct 3, 2024

Proposed changes

  • Let Django handle SIGTERM signals in the docker env

Brief description of rationale

DB's are stateful, so it's important to let them clean up after themselves when killing a docker compose session. This way, django can control how to peacefully shutdown connections to the DB.

It also has the added benefit of decreasing shutdown times from 10.2s to 0.5s.

@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner October 3, 2024 16:14
This way, django can control how to peacefully
shutdown connections to the DB
@alanzhu0 alanzhu0 merged commit c7839a6 into tjcsl:dev Oct 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants