Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve name of docker volume #1747

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

JasonGrace2282
Copy link
Member

Proposed changes

  • Add an explicit name to pgdata volume

Brief description of rationale

By default, docker prefixes volumes in a compose.yaml with the name of the folder it's in. For our case, that would make the volume called docker_pgdata. However, this means that any other project that has its docker compose in a folder called docker and doesn't give a special name to the pgdata volume will conflict with Ion.

Yes, this happened to me.

Things to consider

If there's any important data in the original volume, it may need to be copied over to the new volume.

@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner February 5, 2025 19:11
@coveralls
Copy link

Coverage Status

coverage: 79.073% (+0.08%) from 78.994%
when pulling 14680e0 on JasonGrace2282:docker-env
into f77b2df on tjcsl:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants