Add tests for the assignments app
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGrace2282
force-pushed
the
more-tests
branch
2 times, most recently
from
9b4f1eb to
55dc358
Compare
|
I didn't complete every single view in assignments, but I hit most and I think I'm happy with where it is right now. |
JasonGrace2282
force-pushed
the
more-tests
branch
6 times, most recently
from
90a5932 to
348949b
Compare
krishnans2006
previously approved these changes
Jun 6, 2024
JasonGrace2282
force-pushed
the
more-tests
branch
8 times, most recently
from
f2999ca to
348949b
Compare
krishnans2006
force-pushed
the
master
branch
7 times, most recently
from
4109c55 to
e50df1a
Compare
krishnans2006
force-pushed
the
master
branch
2 times, most recently
from
c03ce92 to
090d035
Compare
JasonGrace2282
force-pushed
the
more-tests
branch
from
348949b to
34b3d21
Compare
JasonGrace2282
force-pushed
the
more-tests
branch
2 times, most recently
from
bb98a19 to
7f718d1
Compare
JasonGrace2282
added
area/testing
JasonGrace2282
force-pushed
the
more-tests
branch
2 times, most recently
from
ba2b32c to
ca353a6
Compare
krishnans2006
pushed a commit
that referenced
this pull request
Jun 29, 2024
For an example of the error, run `test_incorrect_files` from #40 locally
|
@JasonGrace2282 could you rebase this PR so I can test it with the changes from #50? |
Also uses pytest-xdist to run tests in parallel
JasonGrace2282
force-pushed
the
more-tests
branch
from
ca353a6 to
554a5a7
Compare
|
Done @krishnans2006 :) |
Improves speed and fixes issues with sandboxing wrappers
krishnans2006
requested changes
Jun 29, 2024
There was a problem hiding this comment.
To recap our conversation, any tests that edit the same file can have edge cases, so you'll need to account for those. For example, test_grader_view and test_download_grader both edit media/assignment-1/grader.py, so one of them can fail if they're timed poorly.
krishnans2006
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add basic tests for every view in
tin/apps/assignments/views.py(see #41 )Feel free to help out ;)
Bonus
I added
pytest-xdistto run tests in parallel (nobody likes a slow CI)Progress