Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode Implementation #83

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Dark mode Implementation #83

wants to merge 17 commits into from

Conversation

hsna674
Copy link

@hsna674 hsna674 commented Sep 5, 2024

Closes #2

  • Adds a new field to the user model called dark_mode
  • Adds the change_theme view to the user views.

@hsna674 hsna674 requested a review from a team as a code owner September 5, 2024 16:18
JasonGrace2282
JasonGrace2282 requested changes Sep 12, 2024
View reviewed changes
tin/apps/users/views.py Outdated Show resolved Hide resolved
tin/apps/users/forms.py Outdated Show resolved Hide resolved
JasonGrace2282
JasonGrace2282 requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in person, can you add a test for the view to make sure it changes the dark mode?
Information on writing tests can be found on the website: https://tjcsl.github.io/tin/contributing/tests.html

tin/templates/base.html Outdated Show resolved Hide resolved
@krishnans2006 krishnans2006 mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGrace2282 JasonGrace2282 JasonGrace2282 requested changes

@krishnans2006 krishnans2006 Awaiting requested review from krishnans2006 krishnans2006 is a code owner automatically assigned from tjcsl/tin-admins

Requested changes must be addressed to merge this pull request.

Assignees

@hsna674 hsna674

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement dark mode
3 participants
@hsna674 @JasonGrace2282 @krishnans2006