Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamps class v2 #69

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Add timestamps class v2 #69

wants to merge 34 commits into from

Commits on Jan 8, 2023

  1. Add timestamps class

    @moi15moi
    moi15moi committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    01e202e View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. Remove format in the method frames_to_ms

    @moi15moi
    moi15moi committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    f9ea3c5 View commit details
    Browse the repository at this point in the history

  2. [Timestamps] Correct set numerator for from_fps

    @moi15moi
    moi15moi committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    933e7fa View commit details
    Browse the repository at this point in the history

  3. Update __init__.py

    @moi15moi
    moi15moi committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    7a9a010 View commit details
    Browse the repository at this point in the history

  4. [timestamps] Format with Black

    @moi15moi
    moi15moi committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    05cae97 View commit details
    Browse the repository at this point in the history

  5. Add test for timestamps

    @moi15moi
    moi15moi committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    e20a23c View commit details
    Browse the repository at this point in the history

  6. Add data timestamps file

    @moi15moi
    moi15moi committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    d848757 View commit details
    Browse the repository at this point in the history

  7. [Timestamps] Clean import

    @moi15moi
    moi15moi committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    aab9981 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. Update shift and make_time with new class Timestamps

    @moi15moi
    moi15moi committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    7b90aa4 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Add video test for timestamps

    @tkarabela
    tkarabela committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    0bc224c View commit details
    Browse the repository at this point in the history

  2. Timestamps fixes

    @tkarabela
    tkarabela committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    e93c453 View commit details
    Browse the repository at this point in the history

  3. Timestamps - fix mypy and Python 3.7 support

    @tkarabela
    tkarabela committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    f637db8 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. [Timestamps\ms_to_frames] Remove default value for time_type

    @moi15moi
    moi15moi committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    84a5b55 View commit details
    Browse the repository at this point in the history

  2. [Timestamps\frames_to_ms] Remove default value for time_type

    @moi15moi
    moi15moi committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    a3375a0 View commit details
    Browse the repository at this point in the history

  3. [microdvd] Remove unnecessary comment

    @moi15moi
    moi15moi committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    3a17394 View commit details
    Browse the repository at this point in the history

  4. [tests\test_timestamps] Add time_type to test

    @moi15moi
    moi15moi committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    0b9d3f3 View commit details
    Browse the repository at this point in the history

  5. [tests\test_time] Add time_type to test

    @moi15moi
    moi15moi committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    1ded5b0 View commit details
    Browse the repository at this point in the history

  6. [ssa_event] Correct test for shifting and raise correctly an error wh… 

    …en frames or fps is None
    @moi15moi
    moi15moi committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    c8e2faf View commit details
    Browse the repository at this point in the history

  7. [test_ssafile\test_shift] Add an event to be able to test properly

    @moi15moi
    moi15moi committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    13ff899 View commit details
    Browse the repository at this point in the history

  8. [timestamps\TimeType] Add documentation

    @moi15moi
    moi15moi committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    95385dc View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. [.gitignore] Add vscode folder

    @moi15moi
    moi15moi committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    b99d2cd View commit details
    Browse the repository at this point in the history

  2. [timestamps] Use simpler algorithm for ms_to_frames and frames_to_ms.… 

    … Also, reformat code
    @moi15moi
    moi15moi committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    e32c7e5 View commit details
    Browse the repository at this point in the history

  3. [tests\data\timestamps\xxx.ass] Remove negative timecode tests

    @moi15moi
    moi15moi committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    b87a05a View commit details
    Browse the repository at this point in the history

  4. [tests\test_timestamps] Add some tests

    @moi15moi
    moi15moi committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    28e681a View commit details
    Browse the repository at this point in the history

  5. [timestamps] Replace round by math.floor + 0.5 

    In general, player like mpv or mpc round up.
If the ms is 0.5, it will round to 1.

So, this commit reproduce this type of rounding, but there is no standard in the video industry
    @moi15moi
    moi15moi committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    fed590e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2023

  1. [timestamps] ms_to_frames use an proved algorithm

    @moi15moi
    moi15moi committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    7d6e1e2 View commit details
    Browse the repository at this point in the history

  2. [test_time] Handle negative ms/frame

    @moi15moi
    moi15moi committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    4f40876 View commit details
    Browse the repository at this point in the history

  3. [ssaevent] If the shift create negative ms, make it 0 

    An subtitle cannot contain negative timestamps, so we make it 0
    @moi15moi
    moi15moi committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    f265d00 View commit details
    Browse the repository at this point in the history

  4. [test_cli] Correct test value

    @moi15moi
    moi15moi committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    3490eaf View commit details
    Browse the repository at this point in the history

  5. [microdvd] Moved from_fps to be able to raise correctly error 

    If the fps was invalid, Timestamps.from_fps would raise an ValueError that would been catched. We don't want that, so I moved out the call to from_fps of the try except
    @moi15moi
    moi15moi committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    ecb1e16 View commit details
    Browse the repository at this point in the history

  6. [test_microdvd] Correct wrong test end value

    @moi15moi
    moi15moi committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    c97aa49 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Update Proof algorithm - ms_to_frames.md

    @moi15moi
    moi15moi authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    dfe9594 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. [timestamps] Round the pts_time 

    Here is the video I used to test this behaviour: https://github.com/lincolnneu/video_frame_rate/blob/master/key_frame_rate_1/120.mp4
    @moi15moi
    moi15moi committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3580e8f View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Merge remote-tracking branch 'upstream/master' into Add-timestamps-cl… 

    …ass-v2
    @moi15moi
    moi15moi committed May 6, 2023
    Configuration menu
    Copy the full SHA
    ab3295a View commit details
    Browse the repository at this point in the history