Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue_137 update the docker compose settings #138

Merged
merged 2 commits into from
Jan 10, 2023
Merged

issue_137 update the docker compose settings #138

merged 2 commits into from
Jan 10, 2023

Conversation

zqian
Copy link
Member

@zqian zqian commented Jan 5, 2023

No description provided.

@pushyamig
Copy link
Contributor

I was able to build successfully and not with out errors as provided in the problem statement.

@pushyamig
Copy link
Contributor

According to Docker

@pushyamig pushyamig closed this Jan 9, 2023
@pushyamig pushyamig reopened this Jan 9, 2023
@pushyamig
Copy link
Contributor

Sorry, accidentally closed the issue, but i reopened now

@pushyamig
Copy link
Contributor

The docker compose up is kept on running for a long time with canvas beta configuration, so this is possibly expected. So I Stopped the process. To me this passes end-to-end testing. is this acceptable level of testing?

pushyamig
pushyamig reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@pushyamig pushyamig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this change works but I have some comments left for clarification purposes since i ran this project long time ago

pushyamig
pushyamig approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@pushyamig pushyamig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build and ran fine.

@zqian zqian merged commit 8dadb6a into tl-its-umich-edu:master Jan 10, 2023
@zqian zqian deleted the issue_137 branch January 10, 2023 22:16
This was referenced Jan 11, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pushyamig pushyamig pushyamig approved these changes

@jonespm jonespm Awaiting requested review from jonespm

@lsloan lsloan Awaiting requested review from lsloan

@ssciolla ssciolla Awaiting requested review from ssciolla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zqian @pushyamig