open-ocr-preprocessor: fix convert-pdf #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a major update to the open-ocr-preprocessor Dockerfile. It updates to the latest Ubuntu LTS, latest Go, and latest available libraries; which in turn enables building PDF pre-processor support. Previously PDF support did not work because the golang version was too outdated and build failed. This is documented in tleyden/open-ocr#117 To shrink the image size I used a two-stage build; where the first stage install the many dependencies necessary for the build, but the end result image only include the few dependencies required in runtime. This shrink the image from 1.72GB to 310MB. Finally, I eliminated the underlaying stroke-width-transform image as it didn't really make sense here anymore; this new image supports both stroke-width-transform and convert-pdf.
|
@sfcodes so sorry, I haven't been able to get to this, but I haven't forgotten about it! |
tleyden
approved these changes
Sep 4, 2019
|
Dockerhub is giving me an error: Will circle back to this. |
|
That is strange.... it works on my DockerHub just fine. Here is the log in fact: build_9b8800a4.txt Any chance you could run it again? Maybe just a fluke. Meanwhile I'll think about it a little more. |
|
@sfcodes I may have figured it out, and I've kicked off another build |
|
Ok it was an issue with my docker<->github account link. It's fixed, and it build ok now. Build logs: https://gist.github.com/tleyden/64bd251b39c1e30a8b68106feb5beffc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by fixing convert-pdf (tleyden/open-ocr#117), but in the process ended up upgrading this entire Dockerfile.
Here is what changed:
All in all this should fix the build issues with the badly outdated tleyden5iwx/open-ocr-preprocessor Docker image, and enable convert-pdf support.
You can pull the resulting image from here: