Using the PDF pre-processor #117
Comments
Thanks for tracking that down! I will update this and post to this issue. |
|
Hi, @tleyden. Any news on the new build? |
|
Hey, sorry I haven't had a chance yet. I will do so soon. |
|
Ok I kicked off new builds: https://cloud.docker.com/repository/docker/tleyden5iwx/open-ocr-2/builds (not sure if these are visible to people) |
|
Thanks, @tleyden. I can't access the above, but these instead:
It seems there's no new build for the latter. Should there be? |
|
The build failed with: https://gist.github.com/tleyden/7de181727c5ab843c87654c8054c6843 I haven't looked closely into it yet. If you have any ideas, please post! |
|
Looks related to streadway/amqp#291 Do you need to bump the Go version maybe? |
|
Thanks @nevvermind! Seems likely. I'm adding a ticket to use go modules. |
|
Hmm, that could take a while, am I right? |
|
@nevvermind I always try to use the most recently Go version. This is why I never encountered this problem. |
|
@nevvermind yeah, I don't think switching to go modules needs to block this... quick fix: bump go version in dockerfile build |
|
Maybe I'm missing the point, I updated go version to 1.12 but problem persists? |
|
@darmanovic you're probably not talking about the go version in the container, which is what matters at build time. I think the underlying problem is this: https://github.com/tleyden/docker/blob/master/stroke-width-transform/Dockerfile#L2
It's using an ancient ubuntu, and therefore an ancient Go version. |
This is a major update to the open-ocr-preprocessor Dockerfile. It updates to the latest Ubuntu LTS, latest Go, and latest available libraries; which in turn enables building PDF pre-processor support. Previously PDF support did not work because the golang version was too outdated and build failed. This is documented in tleyden/open-ocr#117 To shrink the image size I used a two-stage build; where the first stage install the many dependencies necessary for the build, but the end result image only include the few dependencies required in runtime. This shrink the image from 1.72GB to 310MB. Finally, I eliminated the underlaying stroke-width-transform image as it didn't really make sense here anymore; this new image supports both stroke-width-transform and convert-pdf.
This is a major update to the open-ocr-preprocessor Dockerfile. It updates to the latest Ubuntu LTS, latest Go, and latest available libraries; which in turn enables building PDF pre-processor support. Previously PDF support did not work because the golang version was too outdated and build failed. This is documented in tleyden/open-ocr#117 To shrink the image size I used a two-stage build; where the first stage install the many dependencies necessary for the build, but the end result image only include the few dependencies required in runtime. This shrink the image from 1.72GB to 310MB. Finally, I eliminated the underlaying stroke-width-transform image as it didn't really make sense here anymore; this new image supports both stroke-width-transform and convert-pdf.
Firstly, thanks for your effort. It's a cool setup you've done here.
And thanks @xf0e for the PR.
Unfortunately, it seems that one of the Docker images up in DockerHub is out of date. I mean https://hub.docker.com/r/tleyden5iwx/open-ocr-preprocessor. It doesn't seem to contain the PDF pre-processor code added by @xf0e's PR.
The
preprocessor_rpc_worker.gofile is different in the built image than the one found in the master branch.I'm assuming that's why the
No preprocessor found for: "convert-pdf"error happens: #108 (comment)Would you mind checking if the image is up to date with the code, @tleyden, when you've got some time?
The text was updated successfully, but these errors were encountered: