Ladd review1 #607
Merged
Ladd review1 #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bit better. I also removed some redundant text.
|
Updated to restructure the text around ClientHelloOuterAAD. |
cjpatton
approved these changes
Feb 29, 2024
| @@ -1217,6 +1231,13 @@ ClientHellos, as this allows a network attacker to disclose the contents of this | |||
| ClientHello, including the SNI. It MAY attempt to use another server from the | |||
| DNS results, if one is provided. | |||
|
|
|||
| In order to ensure that the retry mechanism works successfully servers | |||
There was a problem hiding this comment.
nit: "ensure" twice in one sentence
Suggested change
| In order to ensure that the retry mechanism works successfully servers | |
| In order to guarantee that the retry mechanism works successfully servers |
| forbids "encrypted_client_hello" in OuterExtensions. This ensures the | ||
| unauthenticated portion of ClientHelloOuter is not incorporated into | ||
| ClientHelloInner. | ||
| An earlier iteration of this specification only | ||
| encrypted and authenticated the "server_name" extension, which left the overall | ||
| ClientHello vulnerable to an analogue of this attack. |
There was a problem hiding this comment.
Orthogonal: Do we want to add a note for the RFC editor to drop this text about "an earlier version of this specification"?
There was a problem hiding this comment.
No, I think this is helpful
Co-authored-by: Christopher Patton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses most of the comments in @wbl's review, except for (1) whether we should recommend grease-psk and (2) restructuring the text around ClientHelloOuterAAD.