llms/googleai: Support deeply nested tool definitions #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nverting the Gemini tool structure.
…nverting the Gemini tool structure.
tmc
reviewed
Feb 13, 2025
| @@ -433,6 +434,112 @@ func testTools(t *testing.T, llm llms.Model) { | |||
| assert.NotZero(t, resp.Choices[0].GenerationInfo["output_tokens"]) | |||
| } | |||
|
|
|||
| func testToolsWithDeeplyNestedToolStructures(t *testing.T, llm llms.Model) { | |||
| t.Helper() | |||
| t.Parallel() | |||
There was a problem hiding this comment.
I don't think t.Parallel calls make sense in helpers, the test function should have this responsibility.
There was a problem hiding this comment.
Thank you for the reminder, I have deleted the "t.Parallel()" code segment.
tmc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Multi-level Conversion for OpenAI Tool Structure
Problem
The current tool structure conversion logic only processes the first level of OpenAI tool definitions, resulting in information loss when handling deeply nested tool structures. This affects the integrity and correctness of complex tool definitions.
Improvements
schemaWorkItemstruct to manage the conversion processTechnical Details
schemaWorkItemtype to track conversion progressImpact
This improvement ensures that complex tool definitions maintain complete structural information during the conversion process, enhancing compatibility with the OpenAI API.
Testing