A bunch of changes back propagated to add-activity just for grins #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gridlist uses the fxFlex media observable now to figure out the columns, rather than a custom event.
Activity service fixed to really return an IActivity observable that includes all the types passed in the array. Created an accordian view in home that breaks things out by activities Uses material accordian. changed allActivities to not include angel which is a dormant activity type (encompassed by investment with a divergent flag)
changed the toolbar to have all the activity types modified the image to mostly work by making width 300 images that are 300px work best...todo: make sure all images meet this spec so that the aspect ratio works for the captions.
Changes some wording in the home template text. Changed the color of the text in the activity grid component to show up better on white backgrounds
Added the core module and some files for auth services, including the user object. new file: src/app/core/auth.service.spec.ts new file: src/app/core/auth.service.ts new file: src/app/core/core.module.ts new file: src/app/core/user.ts
This breaks the app because of some things that need to be moved permanately to core like angularfiredatabase and its config.
fix up all the reference to activity services and activity classes. Move into core module.
completed issue #3 Implemented Login page /login Implemented Admin Guard that checks for admin property Fixed bug where admin was not preserved
refactored to create a shared module, as well as puttin admin stuff in an admin module. change edit activity to look at the right places. Have guards inplace for the right stuff.
Installed the firebase CLI tools and created some of the files used by the database and storage; as well as set the hosting to look at dist. Changed environment so that production works; in particular cleaning up some mishagog around the byte pipe which is not used. Changes to be committed: new file: .firebaserc new file: database.rules.json new file: firebase.json new file: storage.rules
authentication fails because it creates a new firebase app instance. change things to use the angularfire2 app in the service. closes issue #13
generated but have not hooked up activity-detail component Fixed and close #18 login link Fixed and close #17 navigate back to /admin Fixed #14 set the title to Todd Warren made upload work by fixing a reference to firebase/storage new file: src/app/activity-detail/activity-detail.component.css new file: src/app/activity-detail/activity-detail.component.html new file: src/app/activity-detail/activity-detail.component.spec.ts new file: src/app/activity-detail/activity-detail.component.ts
changed grid and made detail work inclduing backing service which can now search by name; and refers the first one.
Fixed Issue #29, Issue #26, Issue #21 Updated to the newest angularfire 5, which changes the api to observables. Have not tested the editing portions of the app yet. also fixed column resizing Changes to be committed: new file: .vscode/settings.json modified: package.json modified: src/app/activity-detail/activity-detail.component.html modified: src/app/activity-grid/activity-grid.component.html modified: src/app/activity-grid/activity-grid.component.ts modified: src/app/add-activity/add-activity.component.html modified: src/app/add-activity/add-activity.component.ts modified: src/app/app.component.html modified: src/app/core/act-service.service.ts modified: src/app/core/activity-data-fb-mock.ts modified: src/app/edit-activity/edit-activity.component.html modified: src/app/home/home.component.html modified: src/app/input-file/input-file.component.html modified: src/app/login/login.component.html modified: src/app/shared.module.ts modified: src/app/social-nets/social-nets.component.html
In particular some observable mapping to deal with the lost of key$ and some changes around how angularfire relates to firestore file storage.
use the last 5 digest of the time number pre pended to the file name. could have a collision but unlikely.
Also added appropriate changes to grid component, routing, and associated logos. Note: these pages are not data driven
used in AppComponent, the Service load, and the activity grid.
- new flexbox - new angularfire - new angular still to do: didn't add angular.json to the repo do that next.
needed by new angular.
- added medium to social page - update firebase imports to eliminate console complain - Added blog to overview and social page
- get core dependencies to 8 - cdk and material upgrade to 8 - flexlayout to @8.0.0-beta - fixed @ViewChild to be compatible with changes.
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.0.12 to 4.7.7. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.0.12...v4.7.7) Signed-off-by: dependabot[bot] <[email protected]>
…lebars-4.7.7 Bump handlebars from 4.0.12 to 4.7.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just testing out creating pull requests to see how it goes...