feat(core): add version check to sign in #9219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphite-app
bot
requested review from
pengx17,
forehalo,
EYHN and
CatsJuice
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## darksky/version-check #9219 +/- ##
======================================================
Coverage 51.95% 51.95%
======================================================
Files 2140 2140
Lines 97565 97557 -8
Branches 16658 16655 -3
======================================================
+ Hits 50686 50687 +1
+ Misses 45512 45502 -10
- Partials 1367 1368 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
forehalo
reviewed
Dec 20, 2024
packages/frontend/core/src/components/sign-in/sign-in-with-password.tsx
Outdated
Show resolved
Hide resolved
darkskygit
approved these changes
Dec 20, 2024
darkskygit
force-pushed
the
darksky/version-check
branch
from
eb7c0a5 to
6a54784
Compare
darkskygit
force-pushed
the
jimmfly/1220/version-check
branch
from
f019706 to
3cb620d
Compare
darkskygit
approved these changes
Dec 20, 2024
EYHN
reviewed
Dec 23, 2024
packages/frontend/core/src/desktop/pages/auth/oauth-callback.tsx
Outdated
Show resolved
Hide resolved
EYHN
reviewed
Dec 23, 2024
darkskygit
force-pushed
the
darksky/version-check
branch
from
6a54784 to
12b06fa
Compare
JimmFly
force-pushed
the
jimmfly/1220/version-check
branch
2 times, most recently
from
41cea88 to
1f5959c
Compare
EYHN
approved these changes
Dec 23, 2024
darkskygit
force-pushed
the
darksky/version-check
branch
from
12b06fa to
f95fbe9
Compare
darkskygit
force-pushed
the
jimmfly/1220/version-check
branch
from
a3b79d8 to
201d2fc
Compare
JimmFly
force-pushed
the
jimmfly/1220/version-check
branch
from
201d2fc to
7399e3f
Compare
JimmFly
force-pushed
the
jimmfly/1220/version-check
branch
from
7399e3f to
6f315ac
Compare
JimmFly
force-pushed
the
jimmfly/1220/version-check
branch
from
6f315ac to
fc666ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close AF-1742