Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): notion html adapter for embed link block #9279

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Dec 24, 2024

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@donteatfriedrice donteatfriedrice marked this pull request as ready for review December 24, 2024 06:58
@donteatfriedrice donteatfriedrice requested a review from a team as a code owner December 24, 2024 06:58
@graphite-app graphite-app bot requested a review from forehalo December 24, 2024 06:59
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 51.79%. Comparing base (338835a) to head (3b68fa3).

Files with missing lines Patch % Lines
...ine/block-embed/src/common/adapters/notion-html.ts 56.25% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9279      +/-   ##
==========================================
- Coverage   51.83%   51.79%   -0.04%     
==========================================
  Files        2140     2145       +5     
  Lines       97444    97484      +40     
  Branches    16652    16665      +13     
==========================================
- Hits        50506    50488      -18     
- Misses      45576    45638      +62     
+ Partials     1362     1358       -4     
Flag Coverage Δ
server-test 78.08% <ø> (ø)
unittest 30.89% <47.50%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant