Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): at menu loading state #9284

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 24, 2024

fix AF-2017

Copy link
Collaborator Author

pengx17 commented Dec 24, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Dec 24, 2024
@pengx17 pengx17 marked this pull request as ready for review December 24, 2024 08:47
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.77%. Comparing base (cd830d6) to head (14d12ad).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9284      +/-   ##
==========================================
- Coverage   51.79%   51.77%   -0.03%     
==========================================
  Files        2148     2148              
  Lines       97628    97628              
  Branches    16331    16331              
==========================================
- Hits        50570    50543      -27     
- Misses      45743    45770      +27     
  Partials     1315     1315              
Flag Coverage Δ
server-test 78.17% <ø> (-0.07%) ⬇️
unittest 30.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 12-24-feat_core_at_menu_loading_state branch from b9addb6 to 14d12ad Compare December 24, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant