Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ios): disable navigation gesture with js #9287

Merged

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Dec 24, 2024

Do not toggle navigation gesture native to avoid unexpected behavior. close AF-1958, AF-1797

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CatsJuice CatsJuice marked this pull request as ready for review December 24, 2024 09:55
@CatsJuice CatsJuice force-pushed the catsjuice/fix/ios-navigation-gesture-js-control branch from c4b0ae6 to 19c2222 Compare December 24, 2024 10:15
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.84%. Comparing base (50ff365) to head (0acdf62).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9287      +/-   ##
==========================================
+ Coverage   51.82%   51.84%   +0.02%     
==========================================
  Files        2146     2146              
  Lines       97425    97425              
  Branches    16259    16259              
==========================================
+ Hits        50492    50514      +22     
+ Misses      45622    45601      -21     
+ Partials     1311     1310       -1     
Flag Coverage Δ
server-test 78.24% <ø> (+0.06%) ⬆️
unittest 30.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/fix/ios-navigation-gesture-js-control branch 2 times, most recently from 16740da to debe88e Compare December 24, 2024 12:30
Copy link

graphite-app bot commented Dec 25, 2024

Merge activity

  • Dec 24, 10:48 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 24, 11:04 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Unit Test (1)').
  • Dec 24, 11:27 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 24, 11:43 PM EST: A user merged this pull request with the Graphite merge queue.

Brooooooklyn pushed a commit that referenced this pull request Dec 25, 2024
Do not toggle navigation gesture native to avoid unexpected behavior. close AF-1958, AF-1797
@Brooooooklyn Brooooooklyn force-pushed the catsjuice/fix/ios-navigation-gesture-js-control branch from debe88e to 5ae3868 Compare December 25, 2024 03:49
Do not toggle navigation gesture native to avoid unexpected behavior. close AF-1958, AF-1797
@Brooooooklyn Brooooooklyn force-pushed the catsjuice/fix/ios-navigation-gesture-js-control branch from 5ae3868 to 0acdf62 Compare December 25, 2024 04:27
@graphite-app graphite-app bot merged commit 0acdf62 into canary Dec 25, 2024
60 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/ios-navigation-gesture-js-control branch December 25, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants