Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make all docs journal judgement reactive #9290

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added test Related to test cases app:core labels Dec 24, 2024
@CatsJuice CatsJuice marked this pull request as ready for review December 24, 2024 12:11
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.83%. Comparing base (d63ba07) to head (727f21d).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #9290   +/-   ##
=======================================
  Coverage   51.83%   51.83%           
=======================================
  Files        2146     2146           
  Lines       97418    97418           
  Branches    16260    16260           
=======================================
  Hits        50496    50496           
  Misses      45610    45610           
  Partials     1312     1312           
Flag Coverage Δ
server-test 78.24% <ø> (ø)
unittest 30.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/fix/reactive-all-docs-journal-flag branch from 7ddc8a6 to ea65cf7 Compare December 24, 2024 12:29
Copy link

graphite-app bot commented Dec 25, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/fix/reactive-all-docs-journal-flag branch from ea65cf7 to 727f21d Compare December 25, 2024 01:41
@graphite-app graphite-app bot merged commit 727f21d into canary Dec 25, 2024
60 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/reactive-all-docs-journal-flag branch December 25, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants