refactor(component): lit portal #9303

fundon · 2024-12-25T07:25:48Z

removes listeners
adds notify property into LitReactPortal
adds rerendering argument to element factory

Related to #9295 (comment)

fundon · 2024-12-25T07:26:04Z

refactor(component): lit portal #9303 👈 (View in Graphite)
canary

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-12-25T07:51:35Z

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 51.91%. Comparing base (7b572bc) to head (3064f21).
Report is 1 commits behind head on canary.

Files with missing lines	Patch %	Lines
...component/src/lit-react/lit-portal/lite-portal.tsx	0.00%	24 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           canary    #9303      +/-   ##
==========================================
- Coverage   51.94%   51.91%   -0.03%     
==========================================
  Files        2151     2151              
  Lines       97419    97424       +5     
  Branches    16277    16281       +4     
==========================================
- Hits        50600    50579      -21     
- Misses      45505    45531      +26     
  Partials     1314     1314

Flag	Coverage Δ
server-test	`78.17% <ø> (-0.07%)`	⬇️
unittest	`30.98% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pengx17

LGTM

graphite-app · 2024-12-26T02:47:18Z

Merge activity

Dec 25, 9:47 PM EST: A user added this pull request to the Graphite merge queue.
Dec 25, 10:21 PM EST: A user merged this pull request with the Graphite merge queue.

* removes `listeners` * adds `notify` property into `LitReactPortal` * adds `rerendering` argument to element factory Related to #9295 (comment)

github-actions bot added the mod:component label Dec 25, 2024

fundon marked this pull request as ready for review December 25, 2024 07:29

graphite-app bot requested review from CatsJuice, JimmFly, EYHN, pengx17 and forehalo and removed request for JimmFly December 25, 2024 07:29

fundon force-pushed the fundon/12_24_refactor_lite_portal branch 3 times, most recently from 6309afc to 1a329ec Compare December 25, 2024 07:41

pengx17 approved these changes Dec 26, 2024

View reviewed changes

fundon force-pushed the fundon/12_24_refactor_lite_portal branch from 1a329ec to 73739e4 Compare December 26, 2024 01:57

refactor(component): lit portal (#9303)

3064f21

* removes `listeners` * adds `notify` property into `LitReactPortal` * adds `rerendering` argument to element factory Related to #9295 (comment)

EYHN force-pushed the fundon/12_24_refactor_lite_portal branch from 73739e4 to 3064f21 Compare December 26, 2024 03:08

graphite-app bot merged commit 3064f21 into canary Dec 26, 2024
60 checks passed

graphite-app bot deleted the fundon/12_24_refactor_lite_portal branch December 26, 2024 03:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(component): lit portal #9303

refactor(component): lit portal #9303

fundon commented Dec 25, 2024 •

edited

Loading

fundon commented Dec 25, 2024

codecov bot commented Dec 25, 2024 •

edited

Loading

pengx17 left a comment

graphite-app bot commented Dec 26, 2024 •

edited

Loading

refactor(component): lit portal #9303

refactor(component): lit portal #9303

Conversation

fundon commented Dec 25, 2024 • edited Loading

fundon commented Dec 25, 2024

How to use the Graphite Merge Queue

codecov bot commented Dec 25, 2024 • edited Loading

Codecov Report

pengx17 left a comment

Choose a reason for hiding this comment

graphite-app bot commented Dec 26, 2024 • edited Loading

Merge activity

fundon commented Dec 25, 2024 •

edited

Loading

codecov bot commented Dec 25, 2024 •

edited

Loading

graphite-app bot commented Dec 26, 2024 •

edited

Loading