Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): remove deprecated editor slot #9908

Merged

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.51%. Comparing base (3834699) to head (0553ae7).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9908      +/-   ##
==========================================
- Coverage   53.76%   53.51%   -0.26%     
==========================================
  Files        2272     2272              
  Lines      103544   103539       -5     
  Branches    17226    17179      -47     
==========================================
- Hits        55673    55405     -268     
- Misses      46489    46756     +267     
+ Partials     1382     1378       -4     
Flag Coverage Δ
server-test 77.58% <ø> (-0.70%) ⬇️
unittest 31.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review January 28, 2025 04:07
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner January 28, 2025 04:07
@graphite-app graphite-app bot requested review from a team January 28, 2025 04:07
@Saul-Mirone Saul-Mirone force-pushed the 01-28-refactor_editor_remove_deprecated_editor_slot branch from 2d30572 to 24ebe04 Compare January 29, 2025 01:34
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 01-28-refactor_editor_remove_deprecated_editor_slot branch from 24ebe04 to 0553ae7 Compare February 4, 2025 12:56
@graphite-app graphite-app bot merged commit 0553ae7 into canary Feb 4, 2025
63 checks passed
@graphite-app graphite-app bot deleted the 01-28-refactor_editor_remove_deprecated_editor_slot branch February 4, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants