Skip to content

Commit

Permalink
Don't strip Go executables for Windows. (#2395)
Browse files Browse the repository at this point in the history
  • Loading branch information
floitsch authored Jun 11, 2024
1 parent 5b1448c commit b7f366f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,12 @@ jobs:
make BUILD=build-debug BUILD_TYPE=Debug sdk
ccache -s
- name: Strip executables - Linux/Windows
if: runner.os != 'macOS' && (github.event_name == 'release' || inputs.strip == 'true')
# Note: Go executables may not be stripped on Windows.
run: |
strip -s build/host/sdk/bin/*
# Test.
- name: Test
shell: bash # This is crucial, as the powershell doesn't abort when there is an error.
Expand Down Expand Up @@ -209,12 +215,6 @@ jobs:
echo "$TOITLSP" toitdoc -p $CPU_CORES --toitc=$TOITC "--sdk=$SDKDIR" "--out=$JSON_OUT_PATH" --version=$TOIT_VERSION lib
"$TOITLSP" toitdoc -p $CPU_CORES --toitc=$TOITC "--sdk=$SDKDIR" "--out=$JSON_OUT_PATH" --version=$TOIT_VERSION lib
- name: Strip executables - Linux/Windows
if: runner.os != 'macOS' && (github.event_name == 'release' || inputs.strip == 'true')
run: |
strip -s build/host/sdk/bin/*
strip -s build/host/sdk/tools/*
- name: Pack artifacts
if: matrix.shard == 1
shell: bash
Expand Down

0 comments on commit b7f366f

Please sign in to comment.