Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs.rs links to 0.8 #3120

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Update docs.rs links to 0.8 #3120

merged 1 commit into from
Dec 27, 2024

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Dec 27, 2024

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 27, 2024

@syphar @GuillaumeGomez you don't happen to have an idea on how we could improve the situation?

tl;dr axum depends on axum-core, but in the axum-core docs we would ideally like to use intra-doc links to stuff in axum.

@Turbo87 Turbo87 merged commit 33b353d into tokio-rs:main Dec 27, 2024
18 checks passed
@GuillaumeGomez
Copy link

Currently we cannot only link to downstream crates, not upstream. However relative paths work fine, but you will still need to have the version number in the path.

@Turbo87 Turbo87 deleted the doc-links branch December 27, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants