impl Valuable for Path and PathBuf #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
May 14, 2021
valuable/src/valuable.rs
Outdated
Comment on lines
211
to
229
| struct Error; | ||
| static ERROR: Error = Error; | ||
| const MSG: &str = "path is not valid UTF-8 string"; | ||
| impl fmt::Debug for Error { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| fmt::Debug::fmt(&MSG, f) | ||
| } | ||
| } | ||
| impl fmt::Display for Error { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| fmt::Display::fmt(&MSG, f) | ||
| } | ||
| } | ||
| impl std::error::Error for Error {} | ||
|
|
||
| match self.to_str() { | ||
| Some(s) => Value::String(s), | ||
| None => Value::Error(&ERROR), | ||
| } |
There was a problem hiding this comment.
I'm not sure if this is really preferable. Ideally, I would like to call Path::display, but that would be difficult.
There was a problem hiding this comment.
We could consider adding Path as a primitive. What do you think?
Ref: #4
There was a problem hiding this comment.
might be worth having path be a primitive...i can imagine user code wanting to inspect them as paths. OTTOH, this would need to be feature flagged for when the standard library is not in use (since tracing supports no-std + alloc)
There was a problem hiding this comment.
That seems to make sense. Added Value::Path.
carllerche
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.