Use specific AWS driver for Fog #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potomak
reviewed
Oct 5, 2016
| @@ -12,7 +12,7 @@ group :assets do | |||
|
|
|||
| # Upload assets to AWS S3 | |||
| gem 'asset_sync' | |||
| gem 'fog', '~>1.20', require: 'fog/aws/storage' | |||
| gem 'fog-aws', '~> 0.12.0', require: 'fog/aws/storage' | |||
There was a problem hiding this comment.
What is the difference? I put that line because it was suggested by https://github.com/AssetSync/asset_sync#optimized-fog-loading.
There was a problem hiding this comment.
It should relies only on aws as dependency and not all supported drivers by fog.
So bundler hasn't to install every king of fog dependencies...
|
Note: at the moment fog is used only to upload compiled assets to S3, but there's an open issue to remove async_assets as suggested by Heroku docs, see #161. |
|
Ok, I didn't notice the #161 issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.