Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split C files #84

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Split C files #84

merged 4 commits into from
Jan 27, 2025

Conversation

stroiman
Copy link

This is extracting the c files for Object, ObjectTemplate, and FunctionTemplate

You suggested including the first feature, but by only having a review on splitting the C-files, the feature review becomes much simpler, as it's just adding new functions - which I just noticed are not well documented, so I get the time to just add that :)

@stroiman
Copy link
Author

I created another PR, targeting my own branch (this branch) with features. I though I could add you as a reviewer, but appears not to be immediately possible on my own fork.

But you can check this out at least, that's the next set of changes that you can view in isolation.
stroiman#2

@tommie tommie merged commit 13ad32b into tommie:master Jan 27, 2025
8 checks passed
@tommie
Copy link
Owner

tommie commented Jan 27, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants